Skip to content

src: don't use semicolon outside function#33592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codebytere wants to merge 1 commit into from
Closed

src: don't use semicolon outside function #33592

codebytere wants to merge 1 commit into from

Conversation

@codebytere
Copy link
Member

@codebyterecodebytere commented May 27, 2020

This causes a build error in Electron:

../../third_party/electron_node/src/node_watchdog.cc:435:73: error: extra ';' outside of a functionis incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi] NODE_MODULE_CONTEXT_AWARE_INTERNAL(watchdog, node::watchdog::Initialize); ^ 1 error generated.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 27, 2020
mhdawson
mhdawson approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31586/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2020
@codebytere
Copy link
MemberAuthor

codebytere commented May 28, 2020

This might be the most absurd PR i've raised so far 😆

@codebytere
Copy link
MemberAuthor

codebytere commented May 29, 2020

Landed in 0ff3819

codebytere added a commit that referenced this pull request May 29, 2020
@codebytere
src: don't use semicolon outside function
0ff3819
PR-URL: #33592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
@codebyterecodebytere deleted the no-semi branch May 29, 2020 19:45
codebytere added a commit that referenced this pull request Jun 18, 2020
@codebytere
src: don't use semicolon outside function
522fbbc
PR-URL: #33592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere added a commit that referenced this pull request Jun 30, 2020
@codebytere
src: don't use semicolon outside function
0e7d26c
PR-URL: #33592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere added a commit that referenced this pull request Jul 8, 2020
@codebytere
src: don't use semicolon outside function
9c69296
PR-URL: #33592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Merged
codebytere added a commit to electron/electron that referenced this pull request Jul 23, 2020
@codebytere
src: don't use semicolon outside function
63b5950
nodejs/node#33592
codebytere added a commit to electron/electron that referenced this pull request Jul 24, 2020
@codebytere
src: don't use semicolon outside function
59fcb1a
nodejs/node#33592
codebytere added a commit to electron/electron that referenced this pull request Jul 24, 2020
@codebytere
src: don't use semicolon outside function
bc98d4e
nodejs/node#33592
codebytere added a commit to electron/electron that referenced this pull request Jul 24, 2020
@codebytere
src: don't use semicolon outside function
206d62b
nodejs/node#33592
This was referenced Jan 25, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-botsnyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Sep 27, 2022
Open
This was referenced Sep 27, 2022
Open
Open
@137717unity137717unity mentioned this pull request Sep 28, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Sep 28, 2022
Open
@ron-a20ron-a20 mentioned this pull request Sep 28, 2022
Open
This was referenced Sep 28, 2022
Open
Open
@137717unity137717unity mentioned this pull request Jun 23, 2023
Open
@molllyn1molllyn1 mentioned this pull request Jun 23, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Jun 24, 2023
Open
@ron-a20ron-a20 mentioned this pull request Jun 24, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Jun 24, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636baby636 mentioned this pull request Dec 7, 2023
Open
This was referenced Dec 15, 2023
Open
Open
@baby636baby636 mentioned this pull request Jan 6, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@richardlaurichardlaurichardlau approved these changes

@legendecaslegendecaslegendecas approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

@himself65himself65himself65 approved these changes

@juanarboljuanarboljuanarbol approved these changes

+2 more reviewers

@mmarchinimmarchinimmarchini approved these changes

@MarshallOfSoundMarshallOfSoundMarshallOfSound approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@codebytere@nodejs-github-bot@jasnell@addaleax@benjamingr@mmarchini@richardlau@MarshallOfSound@legendecas@BridgeAR@mhdawson@himself65@juanarbol