build: fix node.gyp config#33685
Closed
build: fix node.gyp config #33685
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
addaleax approved these changes Jun 1, 2020
Member
addaleax commented Jun 1, 2020
👍 to fast-tracking |
Collaborator
nodejs-github-bot commented Jun 1, 2020
richardlau approved these changes Jun 1, 2020
cjihrig approved these changes Jun 1, 2020
Collaborator
nodejs-github-bot commented Jun 1, 2020
Collaborator
nodejs-github-bot commented Jun 2, 2020
devsnek approved these changes Jun 2, 2020
targos approved these changes Jun 2, 2020
Member
targos commented Jun 2, 2020
Landed in 81f6dd6 |
targos pushed a commit that referenced this pull request Jun 2, 2020
PR-URL: #33685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
This was referenced Jun 4, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
PR-URL: #33685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Member
codebytere commented Jul 10, 2020
Backport blocked on #33291 |
This was referenced May 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lead to weird config bug on windows.