doc: fix indent in tls resumption example#3372
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
thefourtheye commented Oct 14, 2015
LGTM |
silverwind added a commit that referenced this pull request Oct 15, 2015
Markdown requires 4-space indent to correctly format code blocks. This fixes the example so it's correctly presented as code. PR-URL: #3372 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
ContributorAuthor
silverwind commented Oct 15, 2015
Thanks for review, landed in 503f279. |
Contributor
MylesBorins commented Oct 16, 2015
Should docfixes also land in LTS? @jasnell |
Member
jasnell commented Oct 16, 2015
Yes. So long as they're relevant to that branch ;-) |
silverwind added a commit that referenced this pull request Oct 26, 2015
Markdown requires 4-space indent to correctly format code blocks. This fixes the example so it's correctly presented as code. PR-URL: #3372 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Member
jasnell commented Oct 26, 2015
Landed in v4.x-staging in e223fc7 |
silverwind added a commit that referenced this pull request Oct 29, 2015
Markdown requires 4-space indent to correctly format code blocks. This fixes the example so it's correctly presented as code. PR-URL: #3372 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example added in #3147 was wrongly using a 2-space indent, but markdown requires 4-space for code blocks. This fixes it so this code example is now correctly formatted as a code block.