doc: Document buffer.indexOf changes in v4.2.0#3373
Uh oh!
There was an error while loading. Please reload this page.
Conversation
CHANGELOG.md Outdated
There was a problem hiding this comment.
Are we fine with retroactively changing the changelog like this?
There was a problem hiding this comment.
I'm not really sure it matters either way.
There was a problem hiding this comment.
No one's going to read that anyways, that's for sure. I'm feeling adding to the changelog after the release isn't quite right. Let's remove it.
There was a problem hiding this comment.
Intention from #3258 (comment) but I still need to do a PR for new.nodejs.org
There was a problem hiding this comment.
I see. Still, I think the changelog train has left here.
To avoid such issues in the future: How about we add a relnotes label so people can tag changes that they feel worthy of being mentioned in a release? cc: @nodejs/release.
There was a problem hiding this comment.
+1 on the relnotes label. I'm -1 on making this particular change tho.
jasnell commented Oct 21, 2015
Given the -1's on merging this, I'm inclined to close. Can open if someone feels it's necessary. |
Fishrock123 commented Oct 21, 2015
@jasnell those were only for the changelog bit. The doc part is important. Reopening. |
jasnell commented Oct 21, 2015
Ah, right, completely forgot that the PR had the doc changes. @skomski if you can update the PR to just include the doc change that would be helpful |
doc/api/buffer.markdown Outdated
There was a problem hiding this comment.
This should be buf.indexOf(value[, byteOffset[, encoding]]). If not then the implementation is wrong.
There was a problem hiding this comment.
Actually, since typeof byteOffset === 'number' and typeof encoding === 'string' the arguments should actually be indexOf(value[, byteOffset][, encoding]). Sorry about that.
jasnell commented Nov 5, 2015
@skomski ... ping... did you see the comments from @trevnorris ? |
Fishrock123 commented Nov 10, 2015
Ping @skomski |
skomskiforce-pushed the add-doc-buffer-indexof branch 2 times, most recently from acc4698 to 8d142b1Compare
skomskiforce-pushed the add-doc-buffer-indexof branch from 8d142b1 to 9a5ce3cCompare
skomski commented Jan 21, 2016
Updated. |
trevnorris commented Jan 21, 2016
Thanks. I'll land this after #4803. I incorrectly believed that |
There was a problem hiding this comment.
Is this amount of linebreaks really necessary?
PR-URL: #3373 Reviewed-By: Trevor Norris <[email protected]>
trevnorris commented Jan 22, 2016
Landed with whitespace changes, and made example match existing pattern, in 2bcea02. Thanks much! |
PR-URL: #3373 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins commented Jan 28, 2016
@trevnorris this is not landing cleanly into the lts branch. We will likely need to see the changes from #4370 ported over before this can land. |
PR-URL: #3373 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #3373 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #3373 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#3373 Reviewed-By: Trevor Norris <[email protected]>
7 participants
No description provided.