http: used already defined validator for boolean check#33731
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We already importing the validator for integer check. So leveraging the boolean check validator to remove already defined logic in the code and thus making it DRY.
jasnell approved these changes Jun 4, 2020
lundibundi approved these changes Jun 4, 2020
Collaborator
nodejs-github-bot commented Jun 4, 2020
cjihrig approved these changes Jun 4, 2020
This was referenced Jun 6, 2020
rexagod approved these changes Jun 8, 2020
This was referenced Jun 9, 2020
ronag added the author ready Collaborator
nodejs-github-bot commented Jun 21, 2020
30 tasks
trivikr approved these changes Jun 22, 2020
Collaborator
nodejs-github-bot commented Jun 22, 2020
This was referenced Jun 23, 2020
jasnell pushed a commit that referenced this pull request Jun 24, 2020
We already importing the validator for integer check. So leveraging the boolean check validator to remove already defined logic in the code and thus making it DRY. PR-URL: #33731 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Member
jasnell commented Jun 24, 2020
Landed in 1a90d32 |
This was referenced Jun 25, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
We already importing the validator for integer check. So leveraging the boolean check validator to remove already defined logic in the code and thus making it DRY. PR-URL: #33731 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
We already importing the validator for integer check. So leveraging the boolean check validator to remove already defined logic in the code and thus making it DRY. PR-URL: #33731 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes