src: fix FastStringKey equal operator#33748
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
addaleax approved these changes Jun 5, 2020
jasnell approved these changes Jun 5, 2020
cjihrig approved these changes Jun 5, 2020
MrHeer approved these changes Jun 5, 2020
benjamingr approved these changes Jun 5, 2020
addaleax added the author ready 
Collaborator
nodejs-github-bot commented Jun 12, 2020
Collaborator
nodejs-github-bot commented Jun 19, 2020
Collaborator
nodejs-github-bot commented Jun 19, 2020
jasnell pushed a commit that referenced this pull request Jun 24, 2020
PR-URL: #33748 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Member
jasnell commented Jun 24, 2020
Landed in 5a0c66 |
codebytere pushed a commit that referenced this pull request Jun 27, 2020
PR-URL: #33748 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33748 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Member
codebytere commented Jul 10, 2020
Backport blocked on #33139 |
ContributorAuthor
sapics commented Jul 11, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
==operator. (Currently, there are some cases which returntrue, when the length of string is not same).FastStringKey::HashImplreturn multiple of 33, thus it would be better to movewhileto first.Checklist