Skip to content

Conversation

@mscdex
Copy link
Contributor

Benchmark results (keep in mind listeners is always implicitly multiplied by 2 by the benchmark):

 confidence improvement accuracy (*) (**) (***) events/ee-listeners.js raw='false' listeners=1 n=5000000 -0.96 % ±2.89% ±3.85% ±5.03% events/ee-listeners.js raw='false' listeners=10 n=5000000 *** 7.71 % ±1.48% ±1.98% ±2.61% events/ee-listeners.js raw='false' listeners=100 n=5000000 *** 35.04 % ±0.89% ±1.19% ±1.58% events/ee-listeners.js raw='false' listeners=2 n=5000000 *** 20.62 % ±1.41% ±1.89% ±2.47% events/ee-listeners.js raw='false' listeners=5 n=5000000 *** 27.57 % ±0.80% ±1.07% ±1.40% 
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdexmscdex added events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js. labels Jun 13, 2020
@nodejs-github-bot
Copy link
Collaborator

@ZYSzysZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 16, 2020
@nodejs-github-bot
Copy link
Collaborator

jasnell pushed a commit that referenced this pull request Jun 17, 2020
PR-URL: #33863 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
@jasnell
Copy link
Member

Landed in a4f3206

@jasnelljasnell closed this Jun 17, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
PR-URL: #33863 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33863 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #33863 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.eventsIssues and PRs related to the events subsystem / EventEmitter.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@mscdex@nodejs-github-bot@jasnell@addaleax@lpinca@ronag@MrHeer@Flarna@ZYSzys