crypto: add OP flag constants added in OpenSSL v1.1.1#33929
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ ContributorAuthor
mkrawczuk commented Jun 17, 2020
Full OpenSSL option flag list is available here: Also I have noticed that several OpenSSL constants here are missing description: I think it would be a good idea to add it, or to put a reference to the SSL wiki where the descriptions can be found, or do both. Let me know what you think. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Member
addaleax commented Jun 19, 2020
@nodejs/crypto |
jasnell approved these changes Jun 19, 2020
mildsunrise approved these changes Jun 20, 2020
tniessen approved these changes Jun 20, 2020
Collaborator
nodejs-github-bot commented Jun 22, 2020
Contributor
mildsunrise commented Jun 22, 2020
+1 on doing both |
mkrawczuk added a commit to mkrawczuk/node that referenced this pull request Jun 25, 2020
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to nodejs#33929.
2 tasks
jasnell pushed a commit that referenced this pull request Jul 3, 2020
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: #34050 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: #34050 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: #34050 Reviewed-By: James M Snell <[email protected]>
ContributorAuthor
mkrawczuk commented Aug 5, 2020
This PR seems to have gotten a little stuck. Is there anything that should be done to move further? |
Collaborator
nodejs-github-bot commented Aug 6, 2020
Collaborator
nodejs-github-bot commented Aug 6, 2020
This was referenced Aug 7, 2020
Contributor
mildsunrise commented Aug 7, 2020
Landed in 3306070 |
mildsunrise pushed a commit that referenced this pull request Aug 7, 2020
PR-URL: #33929 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alba Mendez <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Aug 8, 2020
addaleax pushed a commit that referenced this pull request Aug 8, 2020
PR-URL: #33929 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alba Mendez <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Aug 9, 2020
Merged
This was referenced Aug 11, 2020
codebytere pushed a commit that referenced this pull request Aug 11, 2020
PR-URL: #33929 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alba Mendez <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: #34050 Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #33929 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alba Mendez <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #33929 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alba Mendez <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes