timers: fix multipleResolves in promisified timeouts/immediates#33949
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
After successful timer finish the abort event callback would still reject (already resolved promise) upon calling abortController.abort(). Signed-off-by: Denys Otrishko <[email protected]>
nodejs-github-bot added the timers 
Collaborator
nodejs-github-bot commented Jun 18, 2020
devsnek reviewed Jun 18, 2020
Uh oh!
There was an error while loading. Please reload this page.
benjamingr approved these changes Jun 18, 2020
4 tasks
lundibundi added a commit to lundibundi/node that referenced this pull request Jun 18, 2020
Refs: nodejs#33949 (comment) Signed-off-by: Denys Otrishko <[email protected]>
4 tasks
Collaborator
nodejs-github-bot commented Jun 18, 2020
36 tasks
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/31931/ (:yellow_heart:) |
jasnell added the author ready 
addaleax approved these changes Jun 19, 2020
This was referenced Jun 20, 2020
Member
ronag commented Jun 21, 2020
Landed in 64d22c3 |
ronag pushed a commit that referenced this pull request Jun 21, 2020
After successful timer finish the abort event callback would still reject (already resolved promise) upon calling abortController.abort(). Signed-off-by: Denys Otrishko <[email protected]> PR-URL: #33949 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Jun 22, 2020
jasnell pushed a commit that referenced this pull request Jun 24, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <[email protected]> PR-URL: #33951 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
codebytere commented Jun 27, 2020
@lundibundi could you please open a manual backport for this to v14.x-staging? it's conflict-heavy. |
Member
addaleax commented Jun 27, 2020
This depends on #33833, which is labelled dont-land-on-v14.x |
codebytere pushed a commit that referenced this pull request Jun 27, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <[email protected]> PR-URL: #33951 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <[email protected]> PR-URL: #33951 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <[email protected]> PR-URL: #33951 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 14, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <[email protected]> PR-URL: #33951 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
After successful timer finish the abort event callback would still reject (already resolved promise) upon calling abortController.abort(). Signed-off-by: Denys Otrishko <[email protected]> PR-URL: nodejs#33949 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
After successful timer finish the abort event callback would still reject (already resolved promise) upon calling abortController.abort(). Signed-off-by: Denys Otrishko <[email protected]> PR-URL: nodejs#33949 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
After successful timer finish the abort event callback would still reject (already resolved promise) upon calling abortController.abort(). Signed-off-by: Denys Otrishko <[email protected]> PR-URL: nodejs#33949 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
After successful timer finish the abort event callback would still reject (already resolved promise) upon calling abortController.abort(). Signed-off-by: Denys Otrishko <[email protected]> PR-URL: #33949 Backport-PR-URL: #38386 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos added backported-to-v14.x and removed author ready 
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().
Signed-off-by: Denys Otrishko [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @jasnell @nodejs/timers