Skip to content

src: fix ParseEncoding#33957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sapics wants to merge 1 commit into from
Closed

src: fix ParseEncoding #33957

sapics wants to merge 1 commit into from

Conversation

@sapics
Copy link
Contributor

@sapicssapics commented Jun 19, 2020•
edited
Loading

This PR fixes ParseEncoding.

  1. Remove pointer skip
    "utf-16LE" was parsed "UNKNOWN", this fixes to "UCS2"
    "utf-buffer" was parsed "BUFFER", this fixes to "UNKNOWN"

  2. Add +1 check character length to strncmp for checking end of character
    "utf-16leNOT" was parsed "UCS2", this fixes to "UNKNOWN"

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 19, 2020
@sapicssapicsforce-pushed the src/fix-parse-encoding branch from ead890d to 25f04b5CompareJune 19, 2020 00:48
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31945/

@sapics
src: fix ParseEncoding
06fc9cc
"utf-16LE" was parsed "UNKNOWN", this fixes to "UCS2" "utf-buffer" was parsed "BUFFER", this fixes to "UNKNOWN" "utf-16leNOT" was parsed "UCS2", this fixes to "UNKNOWN"
@sapicssapicsforce-pushed the src/fix-parse-encoding branch from 25f04b5 to 06fc9ccCompareJune 24, 2020 23:53
@sapics
Copy link
ContributorAuthor

sapics commented Jun 24, 2020

I rebased to resolve conflicts

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 25, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32073/

jasnell pushed a commit that referenced this pull request Jun 25, 2020
@sapics@jasnell
src: fix ParseEncoding
bc23d10
"utf-16LE" was parsed "UNKNOWN", this fixes to "UCS2" "utf-buffer" was parsed "BUFFER", this fixes to "UNKNOWN" "utf-16leNOT" was parsed "UCS2", this fixes to "UNKNOWN" PR-URL: #33957 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 25, 2020

Landed in bc23d10

@jasnelljasnell closed this Jun 25, 2020
@sapicssapics deleted the src/fix-parse-encoding branch June 25, 2020 16:37
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@sapics@codebytere
src: fix ParseEncoding
a789474
"utf-16LE" was parsed "UNKNOWN", this fixes to "UCS2" "utf-buffer" was parsed "BUFFER", this fixes to "UNKNOWN" "utf-16leNOT" was parsed "UCS2", this fixes to "UNKNOWN" PR-URL: #33957 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@sapics@codebytere
src: fix ParseEncoding
5692d5e
"utf-16LE" was parsed "UNKNOWN", this fixes to "UCS2" "utf-buffer" was parsed "BUFFER", this fixes to "UNKNOWN" "utf-16leNOT" was parsed "UCS2", this fixes to "UNKNOWN" PR-URL: #33957 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 27, 2020
@sapics@addaleax
src: fix ParseEncoding
b359c11
"utf-16LE" was parsed "UNKNOWN", this fixes to "UCS2" "utf-buffer" was parsed "BUFFER", this fixes to "UNKNOWN" "utf-16leNOT" was parsed "UCS2", this fixes to "UNKNOWN" PR-URL: #33957 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@sapics@addaleax
src: fix ParseEncoding
63cd05b
"utf-16LE" was parsed "UNKNOWN", this fixes to "UCS2" "utf-buffer" was parsed "BUFFER", this fixes to "UNKNOWN" "utf-16leNOT" was parsed "UCS2", this fixes to "UNKNOWN" PR-URL: #33957 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sapics@nodejs-github-bot@jasnell@addaleax