doc: piping from async generators using pipeline()#33992
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
WilliamConnatserforce-pushed the master branch 2 times, most recently from 43d87e5 to d67ecbfCompare
lpinca approved these changes Jun 20, 2020
ronag reviewed Jun 20, 2020
Uh oh!
There was an error while loading. Please reload this page.
Trott reviewed Jun 20, 2020
Uh oh!
There was an error while loading. Please reload this page.
Trott reviewed Jun 20, 2020
Uh oh!
There was an error while loading. Please reload this page.
Member
ronag commented Jun 21, 2020
Maybe this should wait for #33991? |
Member
mcollina commented Jun 21, 2020
I think we might want to iterate on that a bit more, so if this is ready we should land. |
ContributorAuthor
WilliamConnatser commented Jun 21, 2020
Thank ya'll for your feedback. I have implemented all edits which were suggested in review. Let me know if anyone has any more suggestions. |
ronag approved these changes Jun 21, 2020
Member
mcollina commented Jun 22, 2020
trivikr approved these changes Jun 22, 2020
jasnell approved these changes Jun 22, 2020
4 tasks
mcollina pushed a commit that referenced this pull request Jun 22, 2020
PR-URL: #33992 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
mcollina commented Jun 22, 2020
Landed in bfc0e3f |
codebytere pushed a commit that referenced this pull request Jun 27, 2020
PR-URL: #33992 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33992 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be my first contribution, so please let me know if I did something wrong. Thank you!
This PR is an attempt to implement #33644
Although the issue asked I remove the old snippet, after thinking about it more I decided to keep the manual way of handling backpressure and backpressure-related errors in the docs.
Firstly, I think there may be some use case case for having to handle this manually. Secondly, having the manual way to handle this will be useful for anyone looking to gain insight as to how things work under the hood of pipeline().
I did mention pipeline() first and its benefits (that it abstracts the backpressure handling away), so I thought it was a sufficient compromise but I can remove it if ya'll think otherwise.
Checklist