vm: add tests for function declarations using [[DefineOwnProperty]]#34032
+21 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Jul 7, 2020
addaleax added the author ready 
Collaborator
nodejs-github-bot commented Jul 7, 2020
This was referenced Jul 8, 2020
Collaborator
nodejs-github-bot commented Jul 14, 2020
devsnek approved these changes Jul 14, 2020
addaleax pushed a commit that referenced this pull request Jul 15, 2020
Refs: #31808 PR-URL: #34032 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Member
addaleax commented Jul 15, 2020
Landed in 9ae8491 |
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Refs: #31808 PR-URL: #34032 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
Refs: #31808 PR-URL: #34032 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Refs: #31808 PR-URL: #34032 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Refs: #31808 PR-URL: #34032 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:#31808
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesreview?(@devsnek)