test: skip some IBM i unsupported test cases#34118
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program. This leads to timing issues and ECONNRESET failures in some test cases. Refs: libuv/libuv#2782
Member
IBM i CI: https://ci.nodejs.org/job/node-test-commit-ibmi/8/nodes=ibmi72-ppc64/ |
richardlau approved these changes Jun 29, 2020
BethGriggs approved these changes Jun 29, 2020
Collaborator
nodejs-github-bot commented Jul 3, 2020
richardlau added the author ready Member
richardlau commented Jul 3, 2020
With this PR we're down to a single test failure on IBM i, which is an improvement. Assuming the regular CI (which does not include IBM i) passes we can land this. I'll continue to work with @dmabupt and the rest of the @nodejs/platform-ibmi team to get the IBM i CI passing (i.e. no test failures) before hooking it up to be part of the regular CI. |
jasnell approved these changes Jul 3, 2020
jasnell pushed a commit that referenced this pull request Jul 3, 2020
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program. This leads to timing issues and ECONNRESET failures in some test cases. Refs: libuv/libuv#2782 PR-URL: #34118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Jul 3, 2020
Landed in 07bbadb |
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program. This leads to timing issues and ECONNRESET failures in some test cases. Refs: libuv/libuv#2782 PR-URL: #34118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program. This leads to timing issues and ECONNRESET failures in some test cases. Refs: libuv/libuv#2782 PR-URL: #34118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program. This leads to timing issues and ECONNRESET failures in some test cases. Refs: libuv/libuv#2782 PR-URL: #34118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program.
This leads to timing issues and ECONNRESET failures in some test cases.
Refs: libuv/libuv#2782