doc: Update wording in "Two reading modes"#34119
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
gireeshpunathil approved these changes Jun 29, 2020
Member
gireeshpunathil commented Jun 29, 2020
looks good, with the trailing white space removed in line 717, as shown in the linter |
ContributorAuthor
julienp commented Jun 30, 2020
I've fixed the lint issue. |
himself65 approved these changes Jun 30, 2020
lpinca approved these changes Jun 30, 2020
jasnell approved these changes Jul 3, 2020
jasnell pushed a commit that referenced this pull request Jul 3, 2020
PR-URL: #34119 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Jul 3, 2020
Landed in 647babc |
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #34119 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
PR-URL: #34119 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34119 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes