src: remove unused fields from IsolateData#34139
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
codebytere approved these changes Jun 30, 2020
devnexen approved these changes Jun 30, 2020
addaleax added the author ready 
Collaborator
nodejs-github-bot commented Jun 30, 2020
27 tasks
gireeshpunathil approved these changes Jul 1, 2020
This was referenced Jul 2, 2020
himself65 approved these changes Jul 3, 2020
devsnek approved these changes Jul 3, 2020
jasnell approved these changes Jul 3, 2020
Collaborator
nodejs-github-bot commented Jul 3, 2020
jasnell pushed a commit that referenced this pull request Jul 3, 2020
PR-URL: #34139 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Jul 3, 2020
Landed in ee3243f |
32 tasks
This was referenced Jul 5, 2020
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #34139 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
PR-URL: #34139 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes