test: add regression test for C++-created Buffer transfer#34140
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add a test for a regression that occurs when transferring some `Buffer` objects that were created from C++ to a parent thread. Fixes: nodejs#34126
addaleaxforce-pushed the worker-transfer-buffer-from-crypto branch from a2f8b87 to 0239467Compare
Flarna approved these changes Jun 30, 2020
Collaborator
nodejs-github-bot commented Jun 30, 2020
MemberAuthor
addaleax commented Jul 7, 2020
Landed in cb67be7 |
addaleax added a commit that referenced this pull request Jul 7, 2020
Add a test for a regression that occurs when transferring some `Buffer` objects that were created from C++ to a parent thread. Fixes: #34126 PR-URL: #34140 Reviewed-By: Gerhard Stöbich <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
Add a test for a regression that occurs when transferring some `Buffer` objects that were created from C++ to a parent thread. Fixes: #34126 PR-URL: #34140 Reviewed-By: Gerhard Stöbich <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Add a test for a regression that occurs when transferring some `Buffer` objects that were created from C++ to a parent thread. Fixes: #34126 PR-URL: #34140 Reviewed-By: Gerhard Stöbich <[email protected]>
addaleax added a commit that referenced this pull request Sep 22, 2020
Add a test for a regression that occurs when transferring some `Buffer` objects that were created from C++ to a parent thread. Fixes: #34126 PR-URL: #34140 Reviewed-By: Gerhard Stöbich <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test for a regression that occurs when transferring some
Bufferobjects that were created from C++ to a parent thread.Fixes: #34126
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes