http: add note about timer unref#34143
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
ronag commented Jun 30, 2020
@nodejs/http |
MemberAuthor
ronag commented Jul 8, 2020
@nodejs/http |
jasnell approved these changes Jul 8, 2020
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
LGTM but this is likely something we should revisit at some point.
trivikr approved these changes Jul 9, 2020
MemberAuthor
ronag commented Jul 9, 2020
Landed in e8f5745 |
ronag added a commit that referenced this pull request Jul 9, 2020
PR-URL: #34143 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #34143 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
PR-URL: #34143 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34143 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34143 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tripped me a bit and was not trivial to git blame. Adding a comment.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes