test: remove flaky status from eval_messages test#3420
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its "flaky" status. Fixes: nodejs#2672
MemberAuthor
Trott commented Oct 18, 2015
Member
rvagg commented Oct 19, 2015
lgtm |
Contributor
Fishrock123 commented Oct 19, 2015
LGTM |
Contributor
orangemocha commented Oct 19, 2015
I agree based on the findings you mentioned that this test would be more useful without the flaky status. Even better diligence would be to run this test in a loop and see if the intermittent failures can be reproduced. Locally on a linux box, or in CI with a special test run. I can get to it later this week. |
Member
jasnell commented Oct 20, 2015
LGTM |
Trott added a commit that referenced this pull request Oct 20, 2015
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its "flaky" status. Fixes: #2672 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3420
Member
jasnell commented Oct 20, 2015
Landed in 7cb89f5 |
Trott added a commit that referenced this pull request Oct 21, 2015
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its "flaky" status. Fixes: #2672 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3420
Trott added a commit that referenced this pull request Oct 26, 2015
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its "flaky" status. Fixes: #2672 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3420
Member
jasnell commented Oct 26, 2015
Landed in v4.x-staging in 0c23e81 |
Trott added a commit that referenced this pull request Oct 29, 2015
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its "flaky" status. Fixes: #2672 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3420
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.
Fixes: #2672