doc: reword warnings about sockets passed to subprocesses#34273
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added child_process 
tniessen approved these changes Jul 9, 2020
jasnell approved these changes Jul 9, 2020
jasnell added the author ready 
antsmartian approved these changes Jul 10, 2020
lpinca approved these changes Jul 10, 2020
trivikr approved these changes Jul 11, 2020
MemberAuthor
Trott commented Jul 12, 2020
Landed in ac6ecd6 |
Trott added a commit that referenced this pull request Jul 12, 2020
Make the docs more concise. Make warnings direct ("do not use" and "should") rather than "is not recommended" or "is recommended". PR-URL: #34273 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Contributor
MylesBorins commented Jul 14, 2020
This does not land cleanly on v14.x. Does someone want to backport? |
Trott added a commit to Trott/io.js that referenced this pull request Jul 15, 2020
Make the docs more concise. Make warnings direct ("do not use" and "should") rather than "is not recommended" or "is recommended". PR-URL: nodejs#34273 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>4 tasks
MemberAuthor
Trott commented Jul 15, 2020
@MylesBorins Backport PR: #34377 |
MylesBorins pushed a commit that referenced this pull request Jul 15, 2020
Make the docs more concise. Make warnings direct ("do not use" and "should") rather than "is not recommended" or "is recommended". Backport-PR-URL: #34377 PR-URL: #34273 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Make the docs more concise. Make warnings direct ("do not use" and "should") rather than "is not recommended" or "is recommended". Backport-PR-URL: #34377 PR-URL: #34273 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>addaleax pushed a commit that referenced this pull request Sep 22, 2020
Make the docs more concise. Make warnings direct ("do not use" and "should") rather than "is not recommended" or "is recommended". Backport-PR-URL: #34377 PR-URL: #34273 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>addaleax pushed a commit that referenced this pull request Sep 22, 2020
Make the docs more concise. Make warnings direct ("do not use" and "should") rather than "is not recommended" or "is recommended". Backport-PR-URL: #34377 PR-URL: #34273 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos added backported-to-v14.x and removed author ready Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the docs more concise. Make warnings direct ("do not use" and
"should") rather than "is not recommended" or "is recommended".
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes