test: use mustCall() in pummel test#34327
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Jul 12, 2020
This comment has been minimized.
This comment has been minimized.
Trott added the author ready MemberAuthor
Let's try again, without the typo in the PR number... pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15351/ ✅ |
targos approved these changes Jul 13, 2020
lpinca approved these changes Jul 13, 2020
jasnell approved these changes Jul 14, 2020
Trott added a commit that referenced this pull request Jul 15, 2020
Replace 'exit' check with common.mustCall(). PR-URL: #34327 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
Trott commented Jul 15, 2020
Landed in 3b13032 |
MylesBorins pushed a commit that referenced this pull request Jul 15, 2020
Replace 'exit' check with common.mustCall(). PR-URL: #34327 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Replace 'exit' check with common.mustCall(). PR-URL: #34327 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Replace 'exit' check with common.mustCall(). PR-URL: #34327 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Replace 'exit' check with common.mustCall(). PR-URL: #34327 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Replace 'exit' check with common.mustCall(). PR-URL: #34327 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 'exit' check with common.mustCall().
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes