test: handle app already signed error#34331
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott approved these changes Jul 13, 2020
antsmartian approved these changes Jul 13, 2020
ContributorAuthor
cjihrig commented Jul 13, 2020
This is the wrong approach. I'm going to update this PR to try passing the |
Member
richardlau commented Jul 13, 2020
I'm kind of confused on how the app can be already signed. Aren't the actions run in a pristine environment? (The long build times would suggest so.) |
ContributorAuthor
cjihrig commented Jul 13, 2020
It wasn't clear to me how the app was already signed either. To be honest, I didn't try to figure it out either, as fixing the test seemed more straightforward than diving into the GitHub Actions setup. |
cjihrigforce-pushed the macos branch 2 times, most recently from 2cd6562 to deeadb7Compare
Collaborator
nodejs-github-bot commented Jul 20, 2020
Collaborator
3 tasks
In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition. Refs: nodejs#33944 PR-URL: nodejs#34331 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
cjihrig added a commit that referenced this pull request Jul 23, 2020
In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition. Refs: #33944 PR-URL: #34331 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition. Refs: #33944 PR-URL: #34331 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition. Refs: #33944 PR-URL: #34331 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition. Refs: #33944 PR-URL: #34331 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the GitHub Actions CI, test-macos-app-sandbox.js can fail due
to the application already being signed. This commit updates
the test to handle that condition.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes