doc: add author-ready label ref to onboarding-extras guide#34381
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
richardlau approved these changes Jul 15, 2020
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
The list of labels is almost in alphabetical order. If it was I'd ask for this to be moved to the top of the General section but since the list isn't already sorted ¯\_(ツ)_/¯.
MemberAuthor
ruyadorno commented Jul 15, 2020
@richardlau agreed! I believe the |
addaleax approved these changes Jul 15, 2020
ruyadorno added the author ready 
Member
richardlau commented Jul 15, 2020
I'm going to remove the |
richardlau removed the author ready ruyadornoforce-pushed the add-author-ready-ref-to-onboarding-extras-doc branch from 6e9043e to 780dfbfCompareMemberAuthor
ruyadorno commented Jul 15, 2020
ok @richardlau I amended the commit in order to kickoff CI again (lmk if there's an easier way to do that) 😊 it looks like that incident has been resolved. can you please re-approve just in case? |
richardlau approved these changes Jul 15, 2020
richardlau added the author ready 
trivikr approved these changes Jul 16, 2020
gireeshpunathil approved these changes Jul 16, 2020
juanarbol approved these changes Jul 17, 2020
Flarna approved these changes Jul 17, 2020
jasnell reviewed Jul 17, 2020
Uh oh!
There was an error while loading. Please reload this page.
jasnell reviewed Jul 17, 2020
Uh oh!
There was an error while loading. Please reload this page.
ruyadornoforce-pushed the add-author-ready-ref-to-onboarding-extras-doc branch 2 times, most recently from 8684436 to 8141ab0Compare
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place.
ruyadornoforce-pushed the add-author-ready-ref-to-onboarding-extras-doc branch from 8141ab0 to 5c00e88Compareruyadorno added author ready 
MylesBorins pushed a commit that referenced this pull request Jul 22, 2020
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: #34381 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Contributor
MylesBorins commented Jul 22, 2020
only failure was unrelated CI (for a job we are looking at removing) Landed in bfef588 |
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: #34381 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: #34381 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: #34381 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Myles Borins <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: #34381 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Labels" section of
doc/guides/onboarding-extras.mdwas missing a reference to theauthor-readylabel. This commit adds a description similar to the definition found indoc/guides/collaborator-guide.mdwith the goal of making it easier for new contributors to find labels info all in one place.Just a small improvement suggested during the onboarding session 😊
/cc @addaleax
Checklist
make lintpasses