Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Jul 20, 2020

The index ToC says "About these docs" but the document itself says
"About this documentation" which I think is better. Use that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 20, 2020
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 22, 2020
@Trott
Copy link
MemberAuthor

@nodejs/documentation

@Trott
Copy link
MemberAuthor

Landed in 69c78be

@TrottTrott closed this Jul 23, 2020
@TrottTrott merged commit 69c78be into nodejs:masterJul 23, 2020
@TrottTrott deleted the matchup branch July 23, 2020 13:39
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
The index ToC says "About these docs" but the document itself says "About this documentation" which I think is better. Use that. PR-URL: #34449 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@ruyadornoruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
The index ToC says "About these docs" but the document itself says "About this documentation" which I think is better. Use that. PR-URL: #34449 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
The index ToC says "About these docs" but the document itself says "About this documentation" which I think is better. Use that. PR-URL: #34449 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@lpinca@trivikr@MrHeer@nodejs-github-bot