Skip to content

Conversation

@Trott
Copy link
Member

Moving a couple collaborators who seem relatively inactive to emeriti. /ping @ronkorving@thefourtheye If you'd prefer to remain on the active list, just leave a comment. (It can just be the word "stay" if you want. No need for any justifications or anything like that!) Otherwise, we'll land this in 48 hours. (And even then, you can always be moved back if you become active again.) Thanks for all your great work over the years!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 22, 2020
@Trott
Copy link
MemberAuthor

@nodejs/tsc This will need some reviews/approval.

Copy link
Contributor

@MylesBorinsMylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 23, 2020
@Trott
Copy link
MemberAuthor

Landed in 090ad7d...1ed90e2

Trott added a commit that referenced this pull request Jul 24, 2020
PR-URL: #34471 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
@TrottTrott closed this Jul 24, 2020
@TrottTrott merged commit 1ed90e2 into nodejs:masterJul 24, 2020
@TrottTrott deleted the ron-emeritus branch July 24, 2020 00:53
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
PR-URL: #34471 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
PR-URL: #34471 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
@ruyadornoruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34471 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34471 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34471 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34471 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@MylesBorins@codebytere@targos@nodejs-github-bot