doc: remove breaking-change-helper from onboarding-extras#34497
+0 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
targos approved these changes Jul 24, 2020
Trott added the author ready 
MemberAuthor
Trott commented Jul 25, 2020
This could use a second review. @nodejs/collaborators |
lpinca approved these changes Jul 25, 2020
rexagod approved these changes Jul 25, 2020
antsmartian approved these changes Jul 25, 2020
Trott added a commit that referenced this pull request Jul 25, 2020
I don't think anyone uses the breaking change helper code that is in onboarding-extras. I'm not sure it works for us anyway as I think it will fail if there are any breaking changes since the last release. That may be helpful to releasers, but that is not helpful in determining if an individual commit is semver-major or not. Regardless, I don't think it gets used and I'm interested in not weighing down the onboarding process with a bunch of things that we don't actually use/do. PR-URL: #34497 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
MemberAuthor
Trott commented Jul 25, 2020
Landed in 0679076 |
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
I don't think anyone uses the breaking change helper code that is in onboarding-extras. I'm not sure it works for us anyway as I think it will fail if there are any breaking changes since the last release. That may be helpful to releasers, but that is not helpful in determining if an individual commit is semver-major or not. Regardless, I don't think it gets used and I'm interested in not weighing down the onboarding process with a bunch of things that we don't actually use/do. PR-URL: #34497 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
I don't think anyone uses the breaking change helper code that is in onboarding-extras. I'm not sure it works for us anyway as I think it will fail if there are any breaking changes since the last release. That may be helpful to releasers, but that is not helpful in determining if an individual commit is semver-major or not. Regardless, I don't think it gets used and I'm interested in not weighing down the onboarding process with a bunch of things that we don't actually use/do. PR-URL: #34497 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
I don't think anyone uses the breaking change helper code that is in onboarding-extras. I'm not sure it works for us anyway as I think it will fail if there are any breaking changes since the last release. That may be helpful to releasers, but that is not helpful in determining if an individual commit is semver-major or not. Regardless, I don't think it gets used and I'm interested in not weighing down the onboarding process with a bunch of things that we don't actually use/do. PR-URL: #34497 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think anyone uses the breaking change helper code that is in
onboarding-extras. I'm not sure it works for us anyway as I think it
will fail if there are any breaking changes since the last release. That
may be helpful to releasers, but that is not helpful in determining if
an individual commit is semver-major or not. Regardless, I don't think
it gets used and I'm interested in not weighing down the onboarding
process with a bunch of things that we don't actually use/do.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes