test: fix test-heapdump-zlib#34499
Closed
test: fix test-heapdump-zlib #34499
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
puzpuzpuz added zlib puzpuzpuzforce-pushed the fix/broken-pummel-test-for-zlib branch from 50910cb to 42a4793Compare4 tasks
puzpuzpuzforce-pushed the fix/broken-pummel-test-for-zlib branch from 42a4793 to 6b6841cCompareUh oh!
There was an error while loading. Please reload this page.
puzpuzpuzforce-pushed the fix/broken-pummel-test-for-zlib branch from 6b6841c to 35d87dcCompare
puzpuzpuzforce-pushed the fix/broken-pummel-test-for-zlib branch from 35d87dc to e2fef24Compare
richardlau approved these changes Jul 23, 2020
Member
richardlau commented Jul 23, 2020
I've requested a pummel CI run (queued): https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15556/ |
This comment has been minimized.
This comment has been minimized.
Member
richardlau commented Jul 23, 2020
If the CI's come back green I'd suggest fast tracking to unbreak the daily builds. |
addaleax approved these changes Jul 23, 2020
Trott approved these changes Jul 23, 2020
Trott reviewed Jul 23, 2020
Uh oh!
There was an error while loading. Please reload this page.
Member
Pummel CI re-run: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15561/ ✅ |
Collaborator
nodejs-github-bot commented Jul 23, 2020
Collaborator
nodejs-github-bot commented Jul 24, 2020
6 tasks
Collaborator
nodejs-github-bot commented Jul 24, 2020
Collaborator
nodejs-github-bot commented Jul 24, 2020
Collaborator
nodejs-github-bot commented Jul 24, 2020
Trott pushed a commit that referenced this pull request Jul 24, 2020
PR-URL: #34499 Refs: #34048 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Jul 24, 2020
Landed in d1e4e8e Thanks for the quick fix! |
This was referenced Jul 25, 2020
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
PR-URL: #34499 Refs: #34048 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
3 tasks
Merged
This was referenced Jul 29, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34499 Refs: #34048 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34499 Refs: #34048 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #34048
Fixes
test/pummel/test-heapdump-zlib.jswhich was broken by #34048.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes