doc: use sentence-case for GOVERNANCE.md headers#34503
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the meta 
MemberAuthor
Trott commented Jul 25, 2020
@nodejs/documentation |
targos approved these changes Jul 25, 2020
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
The case of the headers in the TOC should also be changed to be consistent.
MemberAuthor
Trott commented Jul 25, 2020
Thanks! Fixed. |
Trott added the author ready 
richardlau approved these changes Jul 25, 2020
trivikr approved these changes Jul 25, 2020
MemberAuthor
Trott commented Jul 26, 2020
Landed in 7c02446 |
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
Use sentence-case in headers per style guide. PR-URL: #34503 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Use sentence-case in headers per style guide. PR-URL: #34503 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Use sentence-case in headers per style guide. PR-URL: #34503 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use sentence-case in headers per style guide.
Checklist