test: fix test-net-keepalive for AIX#3458
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixed an intermittent issue on AIX where the 100ms timeout was reached before the 'connection' event was fired. This resulted in a failure as serverConnection would be undefined and the assert.equal would throw an error. Changed the flow of the test so that the timeout is only set after a connection has been made.
Member
mhdawson commented Oct 20, 2015
lgtm While the failures were seen on AIX, there is no reason the same failure could not occur on other platforms with the original test so fixing for all make sense. |
Member
mhdawson commented Oct 20, 2015
Member
jasnell commented Oct 21, 2015
LGTM |
Member
jasnell commented Oct 21, 2015
Member
mhdawson commented Oct 21, 2015
Those are known failures on PPC covered by existing defects so we are good to land |
jasnell pushed a commit that referenced this pull request Oct 21, 2015
Fixed an intermittent issue on AIX where the 100ms timeout was reached before the 'connection' event was fired. This resulted in a failure as serverConnection would be undefined and the assert.equal would throw an error. Changed the flow of the test so that the timeout is only set after a connection has been made. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> PR-URL: #3458
Member
jasnell commented Oct 21, 2015
Landed in 87d42b0 |
rvagg pushed a commit that referenced this pull request Oct 22, 2015
Fixed an intermittent issue on AIX where the 100ms timeout was reached before the 'connection' event was fired. This resulted in a failure as serverConnection would be undefined and the assert.equal would throw an error. Changed the flow of the test so that the timeout is only set after a connection has been made. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> PR-URL: #3458
jasnell pushed a commit that referenced this pull request Oct 26, 2015
Fixed an intermittent issue on AIX where the 100ms timeout was reached before the 'connection' event was fired. This resulted in a failure as serverConnection would be undefined and the assert.equal would throw an error. Changed the flow of the test so that the timeout is only set after a connection has been made. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> PR-URL: #3458
Member
jasnell commented Oct 26, 2015
Landed in v4.x-staging in e99823b |
This was referenced Oct 27, 2015
jasnell pushed a commit that referenced this pull request Oct 29, 2015
Fixed an intermittent issue on AIX where the 100ms timeout was reached before the 'connection' event was fired. This resulted in a failure as serverConnection would be undefined and the assert.equal would throw an error. Changed the flow of the test so that the timeout is only set after a connection has been made. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> PR-URL: #3458
This was referenced Nov 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an intermittent issue on AIX where the 100ms timeout was reached
before the 'connection' event was fired. This resulted in a failure as
serverConnection would be undefined and the assert.equal would throw an
error. Changed the flow of the test so that the timeout is only set
after a connection has been made.