doc: update fs.watch() availability for IBM i#34611
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
ghost commented Aug 3, 2020
doc/api/fs.md Outdated
Author
There was a problem hiding this comment.
I didn't add any line suggesting to use fs.watchFile() as this option is mentioned later.
Author
ghost commented Aug 3, 2020
@richardlau take a look when you have a spare minute |
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
Can you undo the unrelated table formatting changes?
Member
richardlau commented Aug 3, 2020
cc @nodejs/platform-ibmi |
Author
ghost commented Aug 3, 2020
@richardlau Sure Probably some formatting is done by my IDE. I'll fix this |
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability
ghost commented Aug 3, 2020
Author
ghost left a comment
ghost left a comment There was a problem hiding this comment.
I've deleted the unnecessary table formatting. That was done automatically by my IDE.
richardlau approved these changes Aug 3, 2020
richardlau added ibm i 
Contributor
ThePrez commented Aug 3, 2020
LGTM. Thanks, @iandrc!! |
Author
ghost commented Aug 3, 2020
@ThePrez np :) |
jasnell approved these changes Aug 7, 2020
jasnell pushed a commit that referenced this pull request Aug 7, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Aug 7, 2020
Landed in 0dff5bc |
addaleax pushed a commit that referenced this pull request Aug 8, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a line that IBM i does not support
fs.watch().Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability
Checklist