n-api: fix use-after-free with napi_remove_async_cleanup_hook#34662
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
Only decrease the size when actually removing items.
This allows using `SetImmediate()` and friends at any point during cleanup.
addaleaxforce-pushed the fix-napi-async-cleanup-uaf branch from 5748020 to b94ceafCompare
gabrielschulhof approved these changes Aug 7, 2020
gabrielschulhof added the fast-track 
Contributor
gabrielschulhof commented Aug 7, 2020
Shall we fast-track, given that this is breaking the CI? |
jasnell approved these changes Aug 7, 2020
Collaborator
nodejs-github-bot commented Aug 7, 2020
jasnell added the author ready Collaborator
nodejs-github-bot commented Aug 7, 2020
Collaborator
jasnell pushed a commit that referenced this pull request Aug 7, 2020
Only decrease the size when actually removing items. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Aug 7, 2020
This allows using `SetImmediate()` and friends at any point during cleanup. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Aug 7, 2020
Fixes: #34657 Refs: #34572 PR-URL: #34662 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Aug 7, 2020
Landed in 9511261, 09c5942, and 262d0d0 |
This was referenced Aug 8, 2020
addaleax added a commit that referenced this pull request Aug 8, 2020
Only decrease the size when actually removing items. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Aug 8, 2020
This allows using `SetImmediate()` and friends at any point during cleanup. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Aug 8, 2020
Fixes: #34657 Refs: #34572 PR-URL: #34662 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 9, 2020
Merged
11 tasks
11 tasks
codebytere pushed a commit that referenced this pull request Aug 11, 2020
Only decrease the size when actually removing items. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Aug 11, 2020
This allows using `SetImmediate()` and friends at any point during cleanup. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Aug 11, 2020
Fixes: #34657 Refs: #34572 PR-URL: #34662 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 12, 2020
addaleax added a commit that referenced this pull request Sep 22, 2020
Only decrease the size when actually removing items. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Sep 22, 2020
This allows using `SetImmediate()` and friends at any point during cleanup. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Sep 22, 2020
Only decrease the size when actually removing items. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Sep 22, 2020
This allows using `SetImmediate()` and friends at any point during cleanup. PR-URL: #34662Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Sep 22, 2020
Fixes: #34657 Refs: #34572 PR-URL: #34662 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #34657
Refs: #34572
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes