doc: add a note about possible missing lines to readline.asyncIterator#34675
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
ContributorAuthor
mikhalev-im commented Aug 8, 2020
Also related to #28565 |
Member
Trott commented Aug 10, 2020
@nodejs/readline |
BridgeAR approved these changes Aug 23, 2020
antsmartian approved these changes Aug 24, 2020
jasnell approved these changes Aug 24, 2020
devsnek approved these changes Aug 24, 2020
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Aug 26, 2020
10 tasks
ContributorAuthor
mikhalev-im commented Aug 29, 2020
Hey guys, I see that some checks failed (not sure why, since only documentation has changed), do I need to act on this somehow? |
Member
Trott commented Aug 29, 2020
No, this is a doc-only change and can land as long as the linter and make-doc jobs have passed (which they have). |
Trott approved these changes Aug 29, 2020
Trott pushed a commit that referenced this pull request Aug 29, 2020
Fixes: #33463 PR-URL: #34675 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Aug 29, 2020
Landed in 33eda80. Thanks for the contribution! 🎉 |
richardlau pushed a commit that referenced this pull request Sep 1, 2020
Fixes: #33463 PR-URL: #34675 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]>
richardlau pushed a commit that referenced this pull request Apr 3, 2022
Fixes: #33463 PR-URL: #34675 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Apr 3, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #33463
Adds a note to the documentation of the
readlinemodule that you may miss lines if you have async operations between interface creation and async iteration (sincereadlineis not a stream).Hopefully I followed the guidelines correctly as this is my first-time contribution.
Checklist