quic,timers: use AbortController with correct name/message#34763
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Aug 13, 2020
Review requested:
|
nodejs-github-bot added dont-land-on-v12.x quic 
jasnell approved these changes Aug 13, 2020
Contributor
aduh95 commented Aug 14, 2020
Typo in the commit message: |
On the web, `AbortError` is the error name, not the error message. Change the code to match that.
On the web, `AbortError` is the error name, not the error message. Change the code to match that.
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 14, 2020
Trott approved these changes Aug 15, 2020
Member
Trott commented Aug 15, 2020
Landed in 9594b54...5d179cb |
Trott pushed a commit that referenced this pull request Aug 15, 2020
On the web, `AbortError` is the error name, not the error message. Change the code to match that. PR-URL: #34763 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott pushed a commit that referenced this pull request Aug 15, 2020
On the web, `AbortError` is the error name, not the error message. Change the code to match that. PR-URL: #34763 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Aug 15, 2020
Any semver concerns with the timers change? |
MemberAuthor
addaleax commented Aug 16, 2020
@Trott Given that |
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
On the web, `AbortError` is the error name, not the error message. Change the code to match that. PR-URL: nodejs#34763 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
On the web, `AbortError` is the error name, not the error message. Change the code to match that. PR-URL: nodejs#34763 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
On the web, `AbortError` is the error name, not the error message. Change the code to match that. PR-URL: nodejs#34763 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
On the web, `AbortError` is the error name, not the error message. Change the code to match that. PR-URL: #34763 Backport-PR-URL: #38386 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quic: use AbortController with correct name/message
On the web,
AbortErroris the error name, not the errormessage. Change the code to match that.
timers: use AbortController with correct name/message
On the web,
AbortErroris the error name, not the errormessage. Change the code to match that.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes