Add caveats section in the doc of crypto #3479
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described.
doc/api/crypto.markdown Outdated
Member
There was a problem hiding this comment.
"... that are considered to be too weak for safe use."
Member
jasnell commented Oct 22, 2015
Looks good in general but a few nits. |
ContributorAuthor
shigeki commented Oct 22, 2015
@jasnell Thanks. I revised the doc and add a commit. |
brendanashworth added crypto doc/api/crypto.markdown Outdated
Member
There was a problem hiding this comment.
"And the API also allows the use of ciphers and hashes with a" (replace to with the)
Member
jasnell commented Oct 22, 2015
Thank you @shigeki ... just a few more I promise ;-). It's great that these recommendations are being updated! |
ContributorAuthor
shigeki commented Oct 22, 2015
Member
jasnell commented Oct 22, 2015
LGTM! Thanks @shigeki ! |
Member
jasnell commented Oct 22, 2015
@indutny ... any feedback before I land? |
Member
jasnell commented Oct 28, 2015
@indutny ... ping? |
shigeki pushed a commit that referenced this pull request Nov 5, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Nov 5, 2015
Landed in 017fc5b |
shigeki pushed a commit that referenced this pull request Nov 7, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
Merged
shigeki pushed a commit that referenced this pull request Nov 16, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Nov 16, 2015
landed in lts-v4.x-staging as 4a94c0a |
shigeki pushed a commit that referenced this pull request Dec 4, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
Closed
shigeki pushed a commit that referenced this pull request Dec 17, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
shigeki pushed a commit that referenced this pull request Dec 23, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is originally from nodejs/node-v0.x-archive#25564.
This adds caveats section in the crypto api documentation to notify users of the risks of weak algorithms and small keys and revises examples to use safe ones.
Fix: #3406