Skip to content

Conversation

@Trott
Copy link
Member

Minor improvements.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@TrottTrott requested a review from a team as a code ownerAugust 21, 2020 21:55
@nodejs-github-botnodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. labels Aug 21, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

Minor improvements. PR-URL: nodejs#34868 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@TrottTrott merged commit 8134c64 into nodejs:masterAug 26, 2020
@Trott
Copy link
MemberAuthor

Landed in 8134c64

@TrottTrott deleted the dgram-minor branch August 26, 2020 13:42
richardlau pushed a commit that referenced this pull request Sep 1, 2020
Minor improvements. PR-URL: #34868 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@richardlaurichardlau mentioned this pull request Sep 2, 2020
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Minor improvements. PR-URL: #34868 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dgramIssues and PRs related to the dgram subsystem / UDP.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@nodejs-github-bot@fhinkel@jasnell@addaleax@trivikr@MrHeer