Skip to content

Conversation

@robhybrid
Copy link

@robhybridrobhybrid commented Aug 30, 2020

doc: fixing typos in Buffer doc.

Checklist

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Aug 30, 2020
@robhybridrobhybrid changed the title doc: pluralized "strings" in hex encoding description.doc: fixing typos in Buffer doc.Aug 30, 2020
Trott pushed a commit that referenced this pull request Sep 1, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@Trott
Copy link
Member

Trott commented Sep 1, 2020

Landed in 59cad32.

Thanks for the contribution! 🎉

@TrottTrott closed this Sep 1, 2020
richardlau pushed a commit that referenced this pull request Sep 1, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@richardlaurichardlau mentioned this pull request Sep 2, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 3, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bufferIssues and PRs related to the buffer subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@robhybrid@Trott@benjamingr@DerekNonGeneric@nodejs-github-bot