docs: error code fix in resolver spec#34998
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Aug 31, 2020
Review requested:
|
nodejs-github-bot added doc 
hybrist approved these changes Aug 31, 2020
ryzokuken approved these changes Sep 1, 2020
guybedford added the author ready guybedford added a commit that referenced this pull request Sep 3, 2020
PR-URL: #34998 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
ContributorAuthor
guybedford commented Sep 3, 2020
Landed in ef4e3b5. |
richardlau pushed a commit that referenced this pull request Sep 7, 2020
PR-URL: #34998 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
PR-URL: #34998 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #34998 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #34998 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#34998 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor docs correction where the error code should be
Invalid Package TargetnotInvalid Module Specifier, which does also affect the resolution behaviour in fallbacks.The spec change is what is already implemented in the resolver itself.
Checklist