Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Sep 3, 2020

URL hashes cannot contain #. Use hashes for the locations that were
intended.

Checklist

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Sep 3, 2020
@Trott
Copy link
MemberAuthor

Trott commented Sep 4, 2020

@nodejs/website

@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2020
@TrottTrottforce-pushed the hash-fix branch 2 times, most recently from 994f269 to 16d058dCompareSeptember 5, 2020 13:50
@TrottTrott merged commit 16d058d into nodejs:masterSep 5, 2020
@Trott
Copy link
MemberAuthor

Trott commented Sep 5, 2020

Landed in 16d058d

@TrottTrott deleted the hash-fix branch September 5, 2020 13:50
URL hashes cannot contain `#`. Use hashes for the locations that were intended. PR-URL: nodejs#35028 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were intended. PR-URL: #35028 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@richardlaurichardlau mentioned this pull request Sep 7, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were intended. PR-URL: #35028 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were intended. PR-URL: #35028 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were intended. PR-URL: #35028 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
URL hashes cannot contain `#`. Use hashes for the locations that were intended. PR-URL: nodejs#35028 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@addaleax@nschonni@targos@tniessen@DerekNonGeneric@nodejs-github-bot