doc: remove duplicate error code entry#35031
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
Closed
MemberAuthor
Trott commented Sep 4, 2020
@nodejs/collaborators This could use reviews. |
Flarna approved these changes Sep 4, 2020
DerekNonGeneric approved these changes Sep 4, 2020
Contributor
DerekNonGeneric left a comment
DerekNonGeneric left a comment There was a problem hiding this comment.
You're right, it is listed twice.
lundibundi approved these changes Sep 5, 2020
lundibundi added the author ready 
tniessen approved these changes Sep 5, 2020
addaleax added the commit-queue 
github-actionsbot removed the commit-queue 
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35031 ✔ Done loading data for nodejs/node/pull/35031 ----------------------------------- PR info ------------------------------------ Title doc: remove duplicate error code entry (#35031) Author Rich Trott (@Trott) Branch Trott:dup-err -> nodejs:master Labels author ready, doc, errors Commits 1 - doc: remove duplicate error code entry Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/35031 Fixes: https://github.com/nodejs/node/issues/35029 Reviewed-By: Gerhard Stöbich Reviewed-By: Derek Lewis Reviewed-By: Denys Otrishko Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35031 Fixes: https://github.com/nodejs/node/issues/35029 Reviewed-By: Gerhard Stöbich Reviewed-By: Derek Lewis Reviewed-By: Denys Otrishko Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Doc-only changes ℹ This PR was created on Thu, 03 Sep 2020 13:59:16 GMT ✔ Approvals: 4 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/35031#pullrequestreview-482946914 ✔ - Derek Lewis (@DerekNonGeneric): https://github.com/nodejs/node/pull/35031#pullrequestreview-482987086 ✔ - Denys Otrishko (@lundibundi): https://github.com/nodejs/node/pull/35031#pullrequestreview-483043807 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/35031#pullrequestreview-483044083 ✖ This PR needs to wait 2 more hours to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
github-actionsbot added the commit-queue-failed addaleax removed the commit-queue-failed 
Fixes: nodejs#35029 PR-URL: nodejs#35031 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MemberAuthor
Trott commented Sep 5, 2020
Landed in 5e99b62 |
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Fixes: #35029 PR-URL: #35031 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Fixes: #35029 PR-URL: #35031 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Fixes: nodejs#35029 PR-URL: nodejs#35031 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #35029
Checklist