test: make .out checks embedder-friendly#35040
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added test 
richardlau approved these changes Sep 3, 2020
cjihrig approved these changes Sep 3, 2020
codebytereforce-pushed the embedder-agnostic-tests branch 2 times, most recently from 13b4d93 to 5f5d473Compare
github-actionsbot removed the request-ci 
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/33058/ (:green_heart:) |
addaleax approved these changes Sep 5, 2020
addaleax added the author ready 
Trott approved these changes Sep 5, 2020
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
It's too bad there's no way to do something like path.basename(process.execPath) within the out files. (Or is there?) LGTM.
Trottforce-pushed the embedder-agnostic-tests branch from 5f5d473 to 3268a9fCompare
Member
Trott commented Sep 5, 2020
Landed in 3268a9f |
PR-URL: nodejs#35040 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
addaleax commented Sep 5, 2020
We could tell the test runner to replace a specific string, e.g. |
richardlau pushed a commit that referenced this pull request Sep 7, 2020
PR-URL: #35040 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
PR-URL: #35040 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Sep 21, 2020
codebytere added a commit to electron/electron that referenced this pull request Sep 21, 2020
codebytere added a commit to electron/electron that referenced this pull request Sep 21, 2020
codebytere added a commit to electron/electron that referenced this pull request Sep 21, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35040 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the color support tests in
pseudo-ttyand some esm tests inmessagewere hardcoded to check the output messages againstnode- this causes failures in Electron's smoke tests against Node.js, since they'll output e.g:(Use `electron --trace-warnings ...` to show where the warning was created)in our case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes