Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Sep 6, 2020

Angle brackets are being used where curly brackets are intended.

Checklist

@TrottTrott requested a review from a teamSeptember 6, 2020 07:42
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 6, 2020
@Trott
Copy link
MemberAuthor

Trott commented Sep 6, 2020

Before (where the <Buffer> disappears because it is interpreted as an HTML tag:
image

After:
image

@Trott
Copy link
MemberAuthor

Trott commented Sep 8, 2020

Landed in ccdd1bd

@TrottTrott merged commit ccdd1bd into nodejs:masterSep 8, 2020
@TrottTrott deleted the quic-curly branch September 8, 2020 13:10
Angle brackets are being used where curly brackets are intended. PR-URL: nodejs#35075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Angle brackets are being used where curly brackets are intended. PR-URL: nodejs#35075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.quicIssues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@addaleax@lpinca@watilde