stream: don't destroy on async iterator success#35122

ronag · 2020-09-09T14:04:59Z

Destroying on async iterator completion ignores autoDestroy.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

ronag · 2020-09-09T14:05:40Z

@richardlau can you give this a try?

mcollina · 2020-09-09T14:08:04Z

As you probably now, this needs a test.

ronag · 2020-09-09T14:09:59Z

As you probably now, this needs a test.

Yes, building... needs another 20 min or so 😄

richardlau · 2020-09-09T14:34:13Z

citgm got (queued): https://ci.nodejs.org/job/citgm-smoker/2464/

ronag · 2020-09-09T14:49:52Z

@nodejs/streams

ronag · 2020-09-09T14:54:00Z

@richardlau Sorry can you start another one. Turns out the first version of this broke a test.

nodejs-github-bot · 2020-09-09T14:54:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33110/

lib/_stream_readable.js

richardlau · 2020-09-09T15:04:52Z

@richardlau Sorry can you start another one. Turns out the first version of this broke a test.

The job is still queued and hasn't started yet. I specified refs/pull/35122/head as the GIT_REMOTE_REF so it should pick up whatever is current when the job actually starts.

lib/_stream_readable.js

mcollina

lgtm

nodejs-github-bot · 2020-09-09T15:52:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33111/

richardlau · 2020-09-09T16:05:41Z

got still appears to be failing with these changes 😞:
e.g. https://ci.nodejs.org/job/citgm-smoker/2464/nodes=rhel7-s390x/testReport/junit/(root)/citgm/got_v11_6_1/

in addition to the time outs there now appear to be two unhandled rejections that weren't seen in an equivalent run against master earlier today:
https://ci.nodejs.org/job/citgm-smoker/2461/nodes=rhel7-s390x/testReport/junit/(root)/citgm/got_v11_6_1/

richardlau · 2020-09-09T16:15:00Z

My working day is drawing to a close but I'll continue to check periodically this evening. If you need to request further CITGM runs, these are the fields to set to test this PR against got:

ronag · 2020-09-09T16:18:28Z

I will dig some more tonight.

richardlau · 2020-09-09T16:29:15Z

Also if you want to run CITGM locally this is what I do:

Rebuild Node.js (e.g. make test)
Run python tools/install.py install ~/sandbox/bin/testnode '' (note the empty quotes at the end) to "install" the rebuilt Node.js into ~/sandbox/bin/testnode (replace directory name as appropriate)
Add ~/sandbox/bin/testnode/bin to my PATH environment variable
In a clone of https://github.com/nodejs/citgm run node bin/citgm got

ronag · 2020-09-12T17:05:37Z

@nodejs/streams this needs another review

ronag · 2020-09-17T21:18:48Z

@nodejs/streams

ronag · 2020-09-21T12:22:29Z

@nodejs/tsc Tomorrow is the cutoff for 15 and I believe it is important that this lands in 15.

Destroying on async iterator completion ignores autoDestroy.

ronag · 2020-09-21T12:26:09Z

rebased to fix conflicts

nodejs-github-bot · 2020-09-21T12:35:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33177/

mcollina

lgtm

github-actions · 2020-09-21T21:38:54Z

Landed in 2b9003b

Destroying on async iterator completion ignores autoDestroy. PR-URL: #35122 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>

MylesBorins · 2020-09-24T18:45:34Z

@ronag this doesn't land cleanly on v14.x, should we backport?

ronag · 2020-09-24T19:20:59Z

@MylesBorins there is already a different WIP PR for that.

includes: * stream: simpler and faster Readable async iterator * stream: don't destroy on async iterator success * stream: async iterator stop read if destroyed PR-URL: #34887 Refs: #34035 Refs: #35122 Refs: #35640 Refs: #34680 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Destroying on async iterator completion ignores autoDestroy. PR-URL: nodejs#35122 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Sep 9, 2020

ronag mentioned this pull request Sep 9, 2020
v14.10.0 changes behavior of existing code (got) #35116
Closed

This was referenced Sep 9, 2020
stream: don't destroy readable before 'end' #35120
Closed
11.6.1 hangs when running on node v14.10.0 sindresorhus/got#1441
Closed

ronag requested a review from mcollina September 9, 2020 14:49

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020

ronag force-pushed the fix-35116-3 branch from 0bc8e65 to 9bb6b8eCompare September 9, 2020 14:52

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020

mcollina reviewed Sep 9, 2020
View reviewed changes

lib/_stream_readable.js Outdated Show resolvedHide resolved

ronag force-pushed the fix-35116-3 branch from babf85f to 4bea14bCompare September 9, 2020 15:08

ronag commented Sep 9, 2020
View reviewed changes

lib/_stream_readable.js Outdated Show resolvedHide resolved

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020

ronag force-pushed the fix-35116-3 branch from e5b721a to 85c997cCompare September 9, 2020 15:17

mcollina approved these changes Sep 9, 2020
View reviewed changes

ronag force-pushed the fix-35116-3 branch from 85c997c to 05d3863Compare September 9, 2020 15:17

addaleax approved these changes Sep 9, 2020
View reviewed changes

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020

ronag requested review from benjamingr and lpinca September 11, 2020 16:45

ronag requested a review from lundibundi September 17, 2020 21:19

mcollina requested a review from jasnell September 17, 2020 21:25

ronag added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Sep 21, 2020

stream: don't destroy on async iterator success
7710846
Destroying on async iterator completion ignores autoDestroy.

ronag force-pushed the fix-35116-3 branch from 8a24d42 to 7710846Compare September 21, 2020 12:26

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2020

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2020

benjamingr approved these changes Sep 21, 2020
View reviewed changes

ronag removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Sep 21, 2020

mcollina approved these changes Sep 21, 2020
View reviewed changes

jasnell approved these changes Sep 21, 2020
View reviewed changes

ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2020

github-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2020

github-actionsbot closed this Sep 21, 2020

MylesBorins added the backport-requested-v14.x label Sep 24, 2020

targos added backported-to-v14.x and removed backport-requested-v14.x labels May 16, 2021

Uh oh!

stream: don't destroy on async iterator success#35122

stream: don't destroy on async iterator success #35122

Uh oh!

Conversation

ronag commented Sep 9, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

ronag commented Sep 9, 2020

Uh oh!

mcollina commented Sep 9, 2020

Uh oh!

ronag commented Sep 9, 2020

Uh oh!

richardlau commented Sep 9, 2020

Uh oh!

ronag commented Sep 9, 2020

Uh oh!

ronag commented Sep 9, 2020

Uh oh!

nodejs-github-bot commented Sep 9, 2020

Uh oh!

Uh oh!

richardlau commented Sep 9, 2020

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 9, 2020

Uh oh!

richardlau commented Sep 9, 2020

Uh oh!

richardlau commented Sep 9, 2020

Uh oh!

ronag commented Sep 9, 2020

Uh oh!

richardlau commented Sep 9, 2020

Uh oh!

ronag commented Sep 12, 2020

Uh oh!

ronag commented Sep 17, 2020

Uh oh!

ronag commented Sep 21, 2020

Uh oh!

ronag commented Sep 21, 2020

Uh oh!

nodejs-github-bot commented Sep 21, 2020

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsbot commented Sep 21, 2020

Uh oh!

MylesBorins commented Sep 24, 2020

Uh oh!

ronag commented Sep 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ronag commented Sep 9, 2020•
edited
Loading