test: introduce a test for process.versions output#352
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
rvagg commented Jan 14, 2015
nice, rigid in the ordering but that's probably OK for now, lgtm |
make sure that process.versions contains an expected list of software to avoid potential mistakes with refactoring.
jbergstroemforce-pushed the test_process_versions branch from 74b1cee to 6a5e0eaCompare
MemberAuthor
jbergstroem commented Jan 14, 2015
@rvagg just pushed an a-z list plus sorting. |
rvagg pushed a commit that referenced this pull request Jan 14, 2015
make sure that process.versions contains an expected list of software to avoid potential mistakes with refactoring. PR-URL: #352 Reviewed-By: Rod Vagg <[email protected]>
Member
rvagg commented Jan 14, 2015
landed in fce1acd |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make sure that process.versions contains an expected list to avoid potential mistakes with refactoring.
/cc @indutny