doc: edit subpath export patterns introduction#35254
Merged
+3 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Sep 18, 2020
Review requested:
|
hybrist approved these changes Sep 18, 2020
doc/api/packages.md Outdated
Member
There was a problem hiding this comment.
Suggested change
| subpaths, this might cause `package.json` bloat and maintenance issues. | |
| this might cause `package.json` bloat and cause maintenance issues. |
guybedford approved these changes Sep 18, 2020
Contributor
guybedford left a comment
guybedford left a comment There was a problem hiding this comment.
Thanks for taking a look at this.
* Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: nodejs#35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
MemberAuthor
Trott commented Sep 21, 2020
Landed in 98768f3 |
Member
ruyadorno commented Sep 21, 2020
The
Until that's all resolved we should not land this patch on v14.x |
MylesBorins pushed a commit that referenced this pull request Sep 24, 2020
* Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: #35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Merged
3 tasks
aduh95 pushed a commit to aduh95/node that referenced this pull request Oct 23, 2020
* Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: nodejs#35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
* Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") Backport-PR-URL: #35757 PR-URL: #35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
* Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") Backport-PR-URL: #35757 PR-URL: #35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
* Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: nodejs#35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist