[v10.x] build: expose napi_build_version variable#35266
Conversation
nodejs-github-bot added build 
Expose `napi_build_version` to allow `node-gyp` to make it available for building native addons. Fixes: nodejs/node-gyp#1745 Refs: nodejs/abi-stable-node#371 PR-URL: nodejs#27835 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
gabrielschulhofforce-pushed the backport-napi_build_version-to-v10.x branch from bf373c5 to 248df1bCompare
gabrielschulhof commented Sep 19, 2020
@NickNaso can you please link the issue that has recently cropped up because we forgot to backport this PR? |
mhdawson left a comment
mhdawson left a comment There was a problem hiding this comment.
LGTM, this seems very low risk and we had an issue reported where a N-API module failed to build because it could not check the value.
NickNaso commented Sep 22, 2020
Hi everybody sorry for the late. |
richardlau commented Sep 22, 2020
Are there likely to be any other n-api related things that need to land on 10.x? We don't have any regular scheduled releases for 10.x now it is in maintenance1 so I'm trying to gauge how much content we'll have to put out in a release. 1To clarify, I'm okay with this landing on 10.x, just working through the logistics of how we actually get it into what release. |
nodejs-github-bot commented Sep 25, 2020
gabrielschulhof commented Sep 25, 2020
@richardlau the PR that marks N-API 7 as stable must still land. |
gabrielschulhof commented Sep 25, 2020
richardlau commented Sep 25, 2020
Thanks. FWIW we discussed the plan for Node.js v10.x at the most recent Release WG meeting (nodejs/Release#614) and the current idea is to look to do a release in about a month's time. |
Expose `napi_build_version` to allow `node-gyp` to make it available for building native addons. Fixes: nodejs/node-gyp#1745 Refs: nodejs/abi-stable-node#371 PR-URL: #27835 Backport-PR-URL: #35266 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
richardlau commented Oct 7, 2020
Landed in b83f9a5. |
5 participants
Expose
napi_build_versionto allownode-gypto make itavailable for building native addons.
Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Reviewed-By: @bnoordhuis
Reviewed-By: @addaleax
Reviewed-By: @gabrielschulhof
Reviewed-By: @lpinca
Reviewed-By: @richardlau
Reviewed-By: @mhdawson
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes