Skip to content

Conversation

@birnam
Copy link
Contributor

Documentation for assert describes:

assert(value[, message]), assert.ok(value[, message]) Tests if value is truthy. It is equivalent to assert.equal(true, !!value, message). 

But assert.equal parameters are actual value first, then expected value. The documentation should read:

assert(value[, message]), assert.ok(value[, message])# Tests if value is truthy. It is equivalent to assert.equal(!!value, true, message). 

@Fishrock123
Copy link
Contributor

@birnam could you prefix the commit message with doc: and make sure it is no longer than 50 characters?

@Fishrock123Fishrock123 added the doc Issues and PRs related to the documentations. label Oct 26, 2015
@birnambirnam changed the title issue-3530 assert.markdown updated to correct 'equivalent' syntax of assert()doc: issue-3530 assert.markdown updatedOct 26, 2015
@birnambirnamforce-pushed the issue-3530-assert-doc-correction branch from 6185451 to 06162e0CompareOctober 26, 2015 18:30
@birnam
Copy link
ContributorAuthor

commit is updated @Fishrock123

@mscdexmscdex added the assert Issues and PRs related to the assert subsystem. label Oct 26, 2015
@evanlucas
Copy link
Contributor

LGTM

1 similar comment
@thefourtheye
Copy link
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Nov 3, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@jasnell
Copy link
Member

Landed in 471aa5a

@jasnelljasnell closed this Nov 3, 2015
@Fishrock123Fishrock123 mentioned this pull request Nov 6, 2015
rvagg pushed a commit that referenced this pull request Nov 7, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@Fishrock123Fishrock123 mentioned this pull request Nov 11, 2015
MylesBorins pushed a commit that referenced this pull request Nov 16, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins
Copy link
Contributor

landed in lts-v4.x-staging as dfc2707

rvagg pushed a commit that referenced this pull request Dec 4, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@jasnelljasnell mentioned this pull request Dec 17, 2015
jasnell pushed a commit that referenced this pull request Dec 17, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assertIssues and PRs related to the assert subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@birnam@Fishrock123@evanlucas@thefourtheye@jasnell@MylesBorins@mscdex