Skip to content

[v10.x] src: allows escaping NODE_OPTIONS with backslashes#35342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rickyes wants to merge 2 commits into from
Closed

[v10.x] src: allows escaping NODE_OPTIONS with backslashes #35342

rickyes wants to merge 2 commits into from

Conversation

@rickyes
Copy link
Contributor

@rickyesrickyes commented Sep 25, 2020•
edited
Loading

The characters specified within NODE_OPTIONS can now be escaped, which
is handy especially in conjunction with --require (where the file path
might happen to contain spaces that shouldn't cause the option to be
split into two).

This PR adds v10.x-compatible commits in addition to backport of #24065.

Fixes: #12971
Refs: microsoft/vscode-js-debug#769
PR-URL: #24065
Reviewed-By: @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Maël Nisonand others added 2 commits September 25, 2020 20:51
@rickyes
src: allows escaping NODE_OPTIONS with backslashes
a2e42eb
The characters specified within NODE_OPTIONS can now be escaped, which is handy especially in conjunction with `--require` (where the file path might happen to contain spaces that shouldn't cause the option to be split into two). Fixes: nodejs#12971 PR-URL: nodejs#24065 Reviewed-By: Anna Henningsen <[email protected]>
@rickyes
fixup! allows escaping NODE_OPTIONS with backslashes
c7e1356
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v10.x labels Sep 25, 2020
@rickyes
Copy link
ContributorAuthor

rickyes commented Sep 25, 2020

/cc @atian25

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33239/

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33242/

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33245/

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33247/

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33250/

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33261/

@rickyes
Copy link
ContributorAuthor

rickyes commented Sep 27, 2020

There are a lot of flaky tests that don't seem to be relevant to this PR, @addaleax@BridgeAR PTAL

@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 27, 2020

Ping @nodejs/LTS

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2020•
edited by rickyes
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33265/ 💛

@rickyesrickyes mentioned this pull request Sep 28, 2020
Closed
4 tasks
richardlau pushed a commit that referenced this pull request Oct 7, 2020
@richardlau
src: allows escaping NODE_OPTIONS with backslashes
2eb6273
The characters specified within NODE_OPTIONS can now be escaped, which is handy especially in conjunction with `--require` (where the file path might happen to contain spaces that shouldn't cause the option to be split into two). Fixes: #12971 PR-URL: #24065 Backport-PR-URL: #35342 Reviewed-By: Anna Henningsen <[email protected]> Refs: microsoft/vscode-js-debug#769
@richardlau
Copy link
Member

richardlau commented Oct 7, 2020

Landed in 2eb6273.

@rickyesrickyes deleted the backport-24065-to-v10.x branch October 10, 2020 04:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes

@addaleaxaddaleaxAwaiting requested review from addaleax

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickyes@nodejs-github-bot@MylesBorins@richardlau