Skip to content

fix(35353) Added feature updateSettings for http2 SecureServer and Server#35383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Vboivin wants to merge 2 commits into from
Closed

fix(35353) Added feature updateSettings for http2 SecureServer and Server #35383

Vboivin wants to merge 2 commits into from

Conversation

@Vboivin
Copy link

@VboivinVboivin commented Sep 28, 2020•
edited
Loading

Fixes#35353

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@VboivinVboivin requested review from a team as code ownersSeptember 28, 2020 00:53
@nodejs-github-botnodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Sep 28, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 28, 2020

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@Vboivin
Copy link
Author

Vboivin commented Sep 28, 2020

This is not done yet, I need to add tests until it is complete

@mscdexmscdex added the wip Issues and PRs that are still a work in progress. label Sep 28, 2020
@Vboivin
Copy link
Author

Vboivin commented Sep 28, 2020

@mscdex This is ready for review.

mcollina
mcollina approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VboivinVboivin mentioned this pull request Sep 28, 2020
Closed
10 tasks
@FlarnaFlarna removed the wip Issues and PRs that are still a work in progress. label Sep 28, 2020
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
Trott
Trott reviewed Sep 30, 2020
View reviewed changes
@TrottTrott added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 30, 2020
@Trott
Copy link
Member

Trott commented Sep 30, 2020

Welcome, @Vboivin, and thanks for the pull request!

lundibundi
lundibundi reviewed Sep 30, 2020
View reviewed changes
@VboivinVboivin requested review from Trott and lundibundi and removed request for a teamOctober 1, 2020 06:45
@Vboivin
Copy link
Author

Vboivin commented Oct 1, 2020

@lundibundi@Trott I did the suggested changes, the PR is ready for review again.

lundibundi
lundibundi approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@lundibundilundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work and thanks for the contribution.

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33317/

@Trott
Copy link
Member

Trott commented Oct 23, 2020•
edited
Loading

Conflicts showed up with the rebasing for the commit queue, so I pulled this down locally, rebased manually, added a fixup for some punctuation nits, and force-pushed. Let's run CI again and if that works out OK, this should be good to land.

@TrottTrott added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 23, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2020•
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33842/ ✅

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2020
@github-actionsgithub-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2020
@github-actions
Copy link
Contributor

github-actionsbot commented Oct 25, 2020

Landed in 1d5b91d...629e1ab

nodejs-github-bot pushed a commit that referenced this pull request Oct 25, 2020
@nodejs-github-bot
http2: add updateSettings to both http2 servers
629e1ab
Allow the user to update the server settings after using http2.createSecureServer() or after using http2.createServer(). Fixes: #35353 PR-URL: #35383 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 25, 2020

Thanks for the contribution! 🎉

targos pushed a commit that referenced this pull request Nov 3, 2020
@targos
http2: add updateSettings to both http2 servers
883ed4b
Allow the user to update the server settings after using http2.createSecureServer() or after using http2.createServer(). Fixes: #35353 PR-URL: #35383 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
targos added a commit that referenced this pull request Nov 3, 2020
@targos
2020-11-04, Version 15.1.0 (Current)
05fdcdf
Notable changes: child_process: * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369 dns: * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824 http: * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895 http2: * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383 lib: * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895 src: * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807 worker: * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664 PR-URL: TODO
@targostargos mentioned this pull request Nov 3, 2020
Merged
targos added a commit that referenced this pull request Nov 3, 2020
@targos
2020-11-04, Version 15.1.0 (Current)
0dd5d63
Notable changes: child_process: * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369 dns: * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824 http: * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895 http2: * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383 lib: * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895 src: * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807 worker: * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664 PR-URL: #35948
MylesBorins pushed a commit that referenced this pull request Nov 4, 2020
@targos@MylesBorins
2020-11-04, Version 15.1.0 (Current)
a90fdc1
Notable changes: child_process: * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369 dns: * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824 http: * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895 http2: * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383 lib: * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895 src: * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807 worker: * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664 PR-URL: #35948
targos added a commit that referenced this pull request Nov 4, 2020
@targos
2020-11-04, Version 15.1.0 (Current)
2291e07
Notable changes: child_process: * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369 dns: * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824 http: * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895 http2: * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383 lib: * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895 src: * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807 worker: * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664 PR-URL: #35948
targos added a commit that referenced this pull request Nov 4, 2020
@targos
2020-11-04, Version 15.1.0 (Current)
8caa6a9
Notable changes: child_process: * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369 dns: * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824 http: * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895 http2: * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383 lib: * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895 src: * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807 worker: * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664 PR-URL: #35948
targos pushed a commit that referenced this pull request May 1, 2021
@targos
http2: add updateSettings to both http2 servers
2e25922
Allow the user to update the server settings after using http2.createSecureServer() or after using http2.createServer(). Fixes: #35353 PR-URL: #35383 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@ZYSzysZYSzysZYSzys approved these changes

+3 more reviewers

@lundibundilundibundilundibundi approved these changes

@apapirovskiapapirovskiapapirovski approved these changes

@rickyesrickyesrickyes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.http2Issues or PRs related to the http2 subsystem.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update HTTP/2 server settings after .listen()

12 participants

@Vboivin@nodejs-github-bot@Trott@ZYSzys@apapirovski@mcollina@jasnell@lundibundi@rickyes@mscdex@aduh95@Flarna