lib: use more global primordials#35397
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Sep 28, 2020
Review requested:
|
nodejs-github-bot added the lib / src This was referenced Sep 28, 2020
ljharb reviewed Sep 28, 2020
Uh oh!
There was an error while loading. Please reload this page.
lpinca approved these changes Sep 28, 2020
gengjiawen approved these changes Sep 29, 2020
rexagod approved these changes Sep 29, 2020
Trott approved these changes Sep 30, 2020
targos commented Oct 2, 2020
Comment on lines +151 to +154
| returnStringPrototypeSplit( | ||
| StringPrototypeReplace(unfqdn(host),/[A-Z]/g,toLowerCase), | ||
| '.' | ||
| ); |
MemberAuthor
Member
There was a problem hiding this comment.
instance method primordials are used often in the node codebase; imo "how it looks" is only relevant once robustness against user code is assured.
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Oct 2, 2020
antsmartian approved these changes Oct 2, 2020
ryzokuken approved these changes Oct 4, 2020
targos pushed a commit that referenced this pull request Oct 4, 2020
PR-URL: #35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2020
PR-URL: #35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2020
PR-URL: #35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2020
PR-URL: #35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
MemberAuthor
targos commented Oct 4, 2020
Landed in b8f34b2...b79829c |
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
PR-URL: #35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
PR-URL: #35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
PR-URL: #35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
PR-URL: #35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
Merged
3 tasks
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR with all the changes of #31209, #31207, #31206 and #31203, after fixing conflicts with the permission of @Sebastien-Ahkrin.