deps: update V8 to 8.6#35415

targos · 2020-09-29T15:25:01Z

No description provided.

nodejs-github-bot · 2020-09-29T15:26:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33287/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3416/

targos · 2020-09-29T15:27:12Z

If CI is green, I will work on releasing the gyp-next changes so we can drop 222c41f

targos · 2020-09-29T15:27:18Z

@nodejs/v8-update

gengjiawen · 2020-09-29T15:27:46Z

If CI is green, I will work on releasing the gyp-next changes so we can drop 222c41f

LGTM

devsnek · 2020-09-29T15:30:22Z

important changes since v8 8.4:

8.5
- Promise.any + AggregateError
- String.prototype.replaceAll
- Logical assignment operators
- WebAssembly multi-value support
- WebAssembly i64<->BigInt support
8.6
- Anonymous classes now have a .name property whose value is the empty string ''.
- \8 and \9 escape sequences are now illegal in template string literals in sloppy mode and in all string literals in strict mode.

nodejs-github-bot · 2020-09-29T18:21:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33290/

targos · 2020-09-29T21:06:01Z

New error on ARM64 Windows:

21:07:10 C:\workspace\node-compile-windows\node\deps\v8\src\compiler\operator.h(196,1): error C2679: binary '<<': no operator found which takes a right-hand operand of type 'const T' (or there is no acceptable conversion) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

nodejs-github-bot · 2020-09-29T21:18:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33294/

targos · 2020-09-30T06:44:11Z

And on ia32:

23:59:43 v8_base_without_compiler.lib(push_registers_masm.obj) : error LNK2026: module unsafe for SAFESEH image. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj] 23:59:48 Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp 23:59:49 ..\..\out\Release\mksnapshot.exe : fatal error LNK1281: Unable to generate SAFESEH image. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj] 23:59:49

targos · 2020-09-30T06:44:23Z

/cc @nodejs/platform-windows

gengjiawen · 2020-09-30T13:25:11Z

New error on ARM64 Windows:

21:07:10 C:\workspace\node-compile-windows\node\deps\v8\src\compiler\operator.h(196,1): error C2679: binary '<<': no operator found which takes a right-hand operand of type 'const T' (or there is no acceptable conversion) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

@richard-townsend-arm any thought on this one ? I tried some fix, but still not work. cc @nodejs/platform-arm

richard-townsend-arm · 2020-09-30T13:58:41Z

Yeah, this is the one of the potential issues I mentioned about compiler health at #25998 (comment)

TL;DR is that there's nobody (apart from Node.js) that's advocating for supporting the MSVC build for Windows on Arm, and without any movement from upstream, it will get more and more difficult to maintain. Microsoft (at least) does care about the Clang build, so I'd recommend switching this platform's compiler in the long run.

I can try and find some time to identify the fix for 8.6.

targos · 2020-09-30T14:14:57Z

@richard-townsend-arm I agree that being able to build with Clang on Windows would be very interesting. I experimented with it some time ago and was blocked on an issue with ICU: #34201
I'll maybe try again with a workaround to see if there are other issues.
In the mean time, we would really like to have V8 8.6 ready for the release of Node.js 15, and we cannot just remove support for MSVC right now so unfortunately, for now, we have to fix the regular issues that happen with this compiler..

gengjiawen · 2020-10-02T13:23:48Z

New error on ARM64 Windows:

21:07:10 C:\workspace\node-compile-windows\node\deps\v8\src\compiler\operator.h(196,1): error C2679: binary '<<': no operator found which takes a right-hand operand of type 'const T' (or there is no acceptable conversion) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

@richard-townsend-arm any thought on this one ? I tried some fix, but still not work. cc @nodejs/platform-arm

Looks like related to template on arm build, if the related code are commented on arm.
The build still failed on arm with

D:\a\node\node\deps\v8\src\base\functional.h(142,1): error C2665: 'v8::internal::compiler::hash_value': none of the 36 overloads could convert all the argument types [D:\a\node\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]D:\a\node\node\deps\v8\src\compiler\machine-operator.h(191,8): message : could be 'size_t v8::internal::compiler::hash_value(v8::internal::compiler::ShiftKind)' [found using argument-dependent lookup] [D:\a\node\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

gengjiawen · 2020-10-03T00:25:31Z

Two things:

Typo in mips config

 '<(V8_ROOT)/src/heap/base/asm/mpis64/push_registers_asm.cc',

Typo in mpis64

windows arm64 generator

 ['_toolset == "host" and host_arch == "x64" or _toolset == "target" and target_arch=="x64"',{'sources': [ '<(V8_ROOT)/src/heap/base/asm/x64/push_registers_masm.S', ], }],

This lead to misconfig in v8_base_without_compiler_host.vcxproj, shouldn't be arm. Not sure we should switch to old config.

 <MARMASM Include="..\..\deps\v8\src\heap\base\asm\x64\push_registers_masm.S"/>

gengjiawen · 2020-10-03T10:40:37Z

Update: Based on #35415
I revert v8 commit v8/v8@fafb476 in gengjiawen@a7687df, hack v8_base_without_compiler_host.vcxproj. But stuck with mksnashot unknown opcode.

gengjiawen · 2020-10-03T13:51:39Z

I have found fix and now back to #35415 (comment).

I believe I found potential issue ... give me some time :)

gengjiawen · 2020-10-03T14:26:34Z

Ok, now I have reach #35415 (comment) without reverting v8 commit. I am not familiar with snapshot for now, don't know who to @ . Maybe @addaleax @joyeecheung

I see v8 8.6 changed part of mksnapshot.cc, not sure related.

C:\Users\runneradmin\Desktop\node\out\Release\obj\v8_snapshot\embedded.S(278): error A2034: unknown opcode: Builtins_RecordWrite [C:\Users\runneradmin\Desktop\node\tools\v8_gypfiles\v8_snapshot.vcxproj]C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\BuildCustomizations\marmasm.targets(70,5): error MSB3721: The command "armasm64.exe ..\..\out\Release\obj\v8_snapshot\\embedded.S -o "..\..\out\Release\obj\v8_snapshot\embedded.obj" " exited with code1. [C:\Users\runneradmin\Desktop\node\tools\v8_gypfiles\v8_snapshot.vcxproj]

joyeecheung · 2020-10-04T14:44:33Z

@gengjiawen Not sure until I see what's in embedded.S or figure out what has changed in the upstream but I guess there's some kind of syntax issue with the emitted assembly - maybe your assembler isn't trying to read it with the correct syntax

gengjiawen · 2020-10-04T15:04:07Z

@gengjiawen Not sure until I see what's in embedded.S or figure out what has changed in the upstream but I guess there's some kind of syntax issue with the emitted assembly - maybe your assembler isn't trying to read it with the correct syntax

@joyeecheung This occurred when we build V8 8.6 arm64 on windows. We have have fix many issues on gyp, not sure related to this. The embedded.S is in https://gist.github.com/gengjiawen/a108f4f6934d15943ed8e731b678ba12.
(To build, you want to get gengjiawen@8944405, and fix v8_base_without_compiler_host.vcxproj <MARMASM -> <MASM manually)

@targos you may want to take a look at arm64 generator in #35415 (comment).

gengjiawen · 2020-10-08T09:02:39Z

I switched to v8 8.5, and found the generated config still is <MARMASM Include="..\..\deps\v8\src\heap\base\asm\x64\push_registers_masm.S"/>

Maybe the new error is due to some linking issue. (The symbol exists in push_registers_masm.S)

v8_base_without_compiler_host.lib(stack.obj) : error LNK2019: unresolved external symbol PushAllRegistersAndIterateStack referenced in function "public: void __cdecl heap::base::Stack::IteratePointers(class heap::base::StackVisitor *)const " (?IteratePointers@Stack@base@heap@@QEBAXPEAVStackVisitor@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]..\..\out\Release\mksnapshot_host.exe : fatal error LNK1120: 1 unresolved externals [D:\a\node\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]

gengjiawen · 2020-10-09T03:55:42Z

Looks v8 8.6 arm64 add v8_Default_embedded_blob_metadata_data_, not sure it's related. (Right side is V8 8.5 arm64)

PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>

PR-URL: #35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: #40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: #40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: #38807 Refs: #38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>

PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>

PR-URL: #35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: #40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: #40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: #38807 Refs: #38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>

PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>

PR-URL: nodejs#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs#38807 Refs: nodejs#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>

PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>

nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Sep 29, 2020

targos mentioned this pull request Sep 29, 2020
deps: update V8 to 8.5 #34337
Closed

gengjiawen added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 29, 2020

gengjiawen mentioned this pull request Sep 29, 2020
V8 currency and Node.js 15 nodejs/TSC#931
Closed

targos force-pushed the v8-86 branch from 222c41f to d5ae6d4Compare September 29, 2020 18:16

gengjiawen mentioned this pull request Oct 2, 2020
support v8 revert nodejs/node-core-utils#504
Open

devsnek mentioned this pull request Oct 10, 2020
Drop 64-bit types from the signatures WebAssembly/WASI#334
Closed

Uh oh!

deps: update V8 to 8.6#35415

deps: update V8 to 8.6 #35415

Uh oh!

Conversation

targos commented Sep 29, 2020

Uh oh!

nodejs-github-bot commented Sep 29, 2020• edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Sep 29, 2020

Uh oh!

targos commented Sep 29, 2020

Uh oh!

gengjiawen commented Sep 29, 2020

Uh oh!

devsnek commented Sep 29, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 29, 2020

Uh oh!

targos commented Sep 29, 2020

Uh oh!

nodejs-github-bot commented Sep 29, 2020

Uh oh!

targos commented Sep 30, 2020

Uh oh!

targos commented Sep 30, 2020

Uh oh!

gengjiawen commented Sep 30, 2020

Uh oh!

richard-townsend-arm commented Sep 30, 2020

Uh oh!

targos commented Sep 30, 2020

Uh oh!

gengjiawen commented Oct 2, 2020

Uh oh!

gengjiawen commented Oct 3, 2020

Typo in mips config

windows arm64 generator

Uh oh!

gengjiawen commented Oct 3, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gengjiawen commented Oct 3, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gengjiawen commented Oct 3, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Oct 4, 2020

Uh oh!

gengjiawen commented Oct 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gengjiawen commented Oct 8, 2020

Uh oh!

gengjiawen commented Oct 9, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

nodejs-github-bot commented Sep 29, 2020•
edited by targos
Loading

devsnek commented Sep 29, 2020•
edited
Loading

gengjiawen commented Oct 3, 2020•
edited
Loading

gengjiawen commented Oct 3, 2020•
edited
Loading

gengjiawen commented Oct 3, 2020•
edited
Loading

gengjiawen commented Oct 4, 2020•
edited
Loading

gengjiawen commented Oct 9, 2020•
edited
Loading