Skip to content

doc: fixup perf_hooks#35527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aduh95 wants to merge 1 commit into from
Closed

doc: fixup perf_hooks #35527

aduh95 wants to merge 1 commit into from

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Oct 6, 2020

v12.19.0 seems to have make some unintended changes to that file, this is my attempt to fix it.

cc @codebytere

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Oct 6, 2020
codebytere
codebytere approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@codebyterecodebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@aduh95aduh95force-pushed the fixup-perf_hooks-doc branch from b703357 to 321b205CompareOctober 7, 2020 07:53
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2020
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020
@github-actionsgithub-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020
@github-actions
Copy link
Contributor

github-actionsbot commented Oct 11, 2020•
edited by aduh95
Loading

Landed in 900f28a

nodejs-github-bot pushed a commit that referenced this pull request Oct 11, 2020
@aduh95@nodejs-github-bot
doc: fixup perf_hooks
900f28a
PR-URL: #35527 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@aduh95aduh95 mentioned this pull request Oct 11, 2020
Closed
4 tasks
@aduh95aduh95 deleted the fixup-perf_hooks-doc branch October 11, 2020 13:55
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@aduh95@MylesBorins
doc: fixup perf_hooks
64ebbdd
PR-URL: #35527 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95@joesepi
doc: fixup perf_hooks
ea46015
PR-URL: nodejs#35527 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebyterecodebyterecodebytere approved these changes

@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.perf_hooksIssues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@codebytere@trivikr@nodejs-github-bot